Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Victor Lenel to members #42

Closed
wants to merge 1 commit into from

Conversation

victorlenel
Copy link

No description provided.

@victorlenel victorlenel requested a review from a team as a code owner February 13, 2025 09:07
@flomonster
Copy link
Contributor

flomonster commented Feb 13, 2025

Sadly, the CI does not work on forked since it requires the GITHUB_APP private key. See the github action logs here

@mxmehl Do you know if there is a workaround for this?

Note

I created the same PR here

@flomonster flomonster closed this Feb 13, 2025
@mxmehl
Copy link
Member

mxmehl commented Feb 13, 2025

There certainly would be a workaround but that would mean that all forks can access this secret - which we probably don't want as it's a public project. I think there is an option that such Runs have to be approved by a member, this could be an alternative.

But the easiest solution is if an existing OSRD member just adds the new user instead of them adding themselves. Org members usually have push access to this repo, and thereby also access to the secret for runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants